Throw an error when using a Union or Interface as an argument type #1222

MAM-SYS · 2021-09-07T19:22:20Z

Hello dear friends @jkimbo @patrick91 @BryceBeagle
This patch is about raising an exception when we use invalid arguments such as Union and Interface. issue #1065
Hope it can help
If anything needs to be changed or fixed, just let me know
With Respect

Description

Types of Changes

Issues Fixed or Closed by This PR

#1065

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

botberry · 2021-09-07T19:25:14Z

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release adds a new exception called InvalidFieldArgument which is raised when a Union or Interface is used as an argument type.
For example this will raise an exception:

import strawberry

@strawberry.type
class Noun:
    text: str

@strawberry.type
class Verb:
    text: str

Word = strawberry.union("Word", types=(Noun, Verb))

@strawberry.field
def add_word(word: Word) -> bool:
	...

Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to Mohammad Hossein Yazdani for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

jkimbo

This looks great @MAM-SYS , thank you! I've added some suggested changes.

strawberry/exceptions.py

strawberry/field.py

RELEASE.md

MAM-SYS · 2021-09-08T14:56:45Z

@jkimbo i appreciate you
It seems my English language is really bad. I need to study more :)
But Thanks for your help. It is very valuable to me
I fixed everything as you suggested, but if anything needs to be fixed again, just tell me
With Respect

jkimbo

Looks good @MAM-SYS ! And your English is very good 😊

I'm going to leave this open for @patrick91 or @BryceBeagle to have a look as well before merging.

patrick91 · 2021-09-10T09:01:02Z

RELEASE.md

@@ -0,0 +1,21 @@
+Release type: patch
+
+This release adds a new exception called `InvalidFieldArgument` which is raised when if a Union or Interface is used as an argument type.


Suggested change

This release adds a new exception called `InvalidFieldArgument` which is raised when if a Union or Interface is used as an argument type.

This release adds a new exception called `InvalidFieldArgument` which is raised when a Union or Interface is used as an argument type.

patrick91 · 2021-09-10T09:03:43Z

tests/fields/test_arguments.py

+def test_union_as_an_argument_type():
+    with pytest.raises(InvalidFieldArgument):
+
+        @strawberry.type
+        class Noun:
+            text: str
+
+        @strawberry.type
+        class Verb:
+            text: str
+
+        Word = strawberry.union("Word", types=(Noun, Verb))
+
+        @strawberry.field
+        def add_word(word: Word) -> bool:
+            return True
+
+
+def test_interface_as_an_argument_type():
+    with pytest.raises(InvalidFieldArgument):
+
+        @strawberry.interface
+        class Adjective:
+            text: str
+
+        @strawberry.field
+        def add_word(adjective: Adjective) -> bool:
+            return True


can we add a test that checks it raises in this case too?

@strawberry.interface class Adjective: text: str def add_word(adjective: Adjective) -> bool: return True @strawberry.type class Mutation: add_word: bool = strawberry.field(resolver=add_word)

patrick91

looks good, just added a couple of minor comments :)

codecov · 2021-09-10T09:10:40Z

Codecov Report

Merging #1222 (8023772) into main (e724177) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
+ Coverage   97.56%   97.58%   +0.02%     
==========================================
  Files          88       88              
  Lines        3321     3358      +37     
  Branches      477      488      +11     
==========================================
+ Hits         3240     3277      +37     
  Misses         45       45              
  Partials       36       36

MAM-SYS · 2021-09-10T09:29:16Z

Thanks for your help and suggestions again @patrick91
Of course, i'll send the changes right now.

patrick91

Nice! Thanks for the PR and for pushing the requested changes :D

botberry · 2021-09-10T10:02:40Z

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥

Throw an error when using a Union or Interface as an argument type

7a08549

botberry added bot:has-release-file labels Sep 7, 2021

jkimbo suggested changes Sep 8, 2021

View reviewed changes

Better suggestions

801ec0f

MAM-SYS force-pushed the issue1065 branch from 20c6cde to 801ec0f Compare September 8, 2021 14:58

MAM-SYS requested a review from jkimbo September 8, 2021 16:48

jkimbo approved these changes Sep 9, 2021

View reviewed changes

patrick91 reviewed Sep 10, 2021

View reviewed changes

Add new test

8023772

MAM-SYS requested a review from patrick91 September 10, 2021 09:47

patrick91 approved these changes Sep 10, 2021

View reviewed changes

patrick91 merged commit 0ec09a6 into strawberry-graphql:main Sep 10, 2021

BryceBeagle mentioned this pull request Sep 12, 2021

Interfaces should not work with input types #1236

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw an error when using a Union or Interface as an argument type #1222

Throw an error when using a Union or Interface as an argument type #1222

MAM-SYS commented Sep 7, 2021

botberry commented Sep 7, 2021 •

edited

Loading

jkimbo left a comment

MAM-SYS commented Sep 8, 2021

jkimbo left a comment

patrick91 Sep 10, 2021

patrick91 Sep 10, 2021

patrick91 left a comment

codecov bot commented Sep 10, 2021 •

edited

Loading

MAM-SYS commented Sep 10, 2021

patrick91 left a comment

botberry commented Sep 10, 2021

		@@ -0,0 +1,21 @@
		Release type: patch

		This release adds a new exception called `InvalidFieldArgument` which is raised when if a Union or Interface is used as an argument type.

Throw an error when using a Union or Interface as an argument type #1222

Throw an error when using a Union or Interface as an argument type #1222

Conversation

MAM-SYS commented Sep 7, 2021

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

botberry commented Sep 7, 2021 • edited Loading

jkimbo left a comment

Choose a reason for hiding this comment

MAM-SYS commented Sep 8, 2021

jkimbo left a comment

Choose a reason for hiding this comment

patrick91 Sep 10, 2021

Choose a reason for hiding this comment

patrick91 Sep 10, 2021

Choose a reason for hiding this comment

patrick91 left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 10, 2021 • edited Loading

Codecov Report

MAM-SYS commented Sep 10, 2021

patrick91 left a comment

Choose a reason for hiding this comment

botberry commented Sep 10, 2021

botberry commented Sep 7, 2021 •

edited

Loading

codecov bot commented Sep 10, 2021 •

edited

Loading